Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing git tags for v2.02 and v2.03 #153

Closed
andylolz opened this issue Mar 3, 2018 · 7 comments
Closed

Missing git tags for v2.02 and v2.03 #153

andylolz opened this issue Mar 3, 2018 · 7 comments

Comments

@andylolz
Copy link
Contributor

andylolz commented Mar 3, 2018

The SSOT page in the docs says I can reference a particular version of the standard as it stood at release (e.g. what could be thought of as 2.03.0) using tags. However, that’s only the case up to v2.01.

The same is true for the component repositories, e.g. the Schema repo.

@andylolz andylolz changed the title Missing tags for v2.02 and v2.03 Missing git tags for v2.02 and v2.03 Sep 19, 2018
@samuele-mattiuzzo
Copy link
Contributor

samuele-mattiuzzo commented Oct 23, 2018

I have been looking into this a bit, it seems like tags were a good idea at first but have been sort of misused: they do refer to the version of the standard the branch points to (version-2.03 for instance) but they have not been kept up to date with the amount of changes, resulting in really old versions being tagged (2014-2015 for the 3 branches tagged). Unless we decide to only commit changes to the versions when a major/minor/patch update to the standard itself happens, they will just be mismatched and cause confusion (as we stand, for instance, we should tag version-2.03 as v2.03.64 -> does not match the Standard version and does not add a relevant piece of information).

Rather than tagging them up every time, I'd suggest we drop the tags idea all together (it's not being used, afaik, anyway) and update the documentation.

The other idea would be to remove and reassign the tags every so often, which isn't a route I'm too keen on at the moment.

@Ocre42 and @andylolz thoughts on this?

@andylolz
Copy link
Contributor Author

andylolz commented Oct 23, 2018

Worth noting that there was an accepted proposal to use semver starting from v3.0.0. At that point, I guess tags will probably become a better way of working, since no-one would want to have a branch for every point version, and especially given it’s exactly what tags are for.


When I created this ticket, I understood tags were used as described at the end of the SSOT doc (linked above), i.e.:

  • branches, which may change for typos and bugfixes e.g. version-1.04, see Branches
  • tags, which point to the exact commit on the day of release e.g. v1.04, see Tags

I guess there could potentially be some use for this… But it’s not really idiomatic, and it’s potentially quite confusing (e.g. someone could be forgiven for thinking they should reference the tag, when 99 times out of 100 they probably should be tracking the version branch).

In summary: I guess (or, hope) most devs know to ignore tags and just use branches. Scrapping tags would probably be fine, except that when v3.0.0 happens, we might want to scrap branches and just use tags.

@samuele-mattiuzzo
Copy link
Contributor

Ok, thanks for that piece of information I wasn't aware of.

Will scrape the tags and adjust the documentation accordingly, confirming deprecation of tags until semver kicks in.

@andylolz
Copy link
Contributor Author

Ok, thanks for that piece of information I wasn't aware of.

Which bit? The semver bit? Now I am doubting myself! Let me try and find a reference…

@samuele-mattiuzzo
Copy link
Contributor

Which bit? The semver bit? Now I am doubting myself! Let me try and find a reference…

Yes that one, although I think Dale mentioned something en passant about it when I met him before starting. If you can resurface the discussion that would be great, although not strictly needed (at least till we reach version 3.x.x... we can talk about it at the TAG 😄 )

@andylolz
Copy link
Contributor Author

If you can resurface the discussion that would be great

Found it! It’s paper 10 from the 2017 Members’ Assembly in Rome:

@samuele-mattiuzzo
Copy link
Contributor

Closed as, for now, all tags have been scraped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants