Create a .new json file, and move, to avoid invalid JSON files on error

IATI · Dec 1, 2014 · 7633460 · 7633460
1 parent cf32728
commit 7633460
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/statsrunner/gitaggregate-publisher.py b/statsrunner/gitaggregate-publisher.py
@@ -40,5 +40,6 @@
                             total[k][commit] = v
 
         for k,v in total.items():
-            with open(os.path.join(git_out_dir, k+'.json'), 'w') as fp:
+            with open(os.path.join(git_out_dir, k+'.json.new'), 'w') as fp:
                 json.dump(v, fp, sort_keys=True, indent=2, default=decimal_default)
+            os.rename(os.path.join(git_out_dir, k+'.json.new'), os.path.join(git_out_dir, k+'.json'))
diff --git a/statsrunner/gitaggregate.py b/statsrunner/gitaggregate.py
@@ -38,5 +38,6 @@
                         total[k][commit] = v
 
 for k,v in total.items():
-    with open(os.path.join(git_out_dir, k+'.json'), 'w') as fp:
+    with open(os.path.join(git_out_dir, k+'.json.new'), 'w') as fp:
         json.dump(v, fp, sort_keys=True, indent=2, default=decimal_default)
+    os.rename(os.path.join(git_out_dir, k+'.json.new'), os.path.join(git_out_dir, k+'.json'))