Merge master into live #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ensure a non-humanitarian activity won’t be included in the “clusters” score or the “appeal or emergency details” score.
`contains_humanitarian_scope` and `uses_humanitarian_clusters_vocab` should only be true for humanitarian activities – it shouldn’t be possible for these to equal 1 if the activity isn’t declared as humanitarian via either the sector code or the humanitarian attribute.
Update reference spend data
Adding UNHCR to reference_spend_data
Changes folder name to reference IATI v2.03 which was released in February 2018. This change appears to have slipped through the cracks of #118
Update folder name for latest IATI version
Adds tests for cases where a non-truthy humanitarian attribute is present.
…ributes are non-empty Fixes the issue described in IATI/IATI-Dashboard#488 (comment)
Makes docstrings consistent with those initially in the file.
Additional humanitarian fix and test suite improvements
Humanitarian dashboard fixes
…I-Stats into add-budget-not-provided
Adding budget-not-provided methods to dashboard.py
|
obviously, thanks Andy. |
samuele-mattiuzzo
approved these changes
Jan 14, 2019
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to get the latest changes on master deployed to production.