Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split comprehensiveness budget and budget-not-provided #149

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

Ocre42
Copy link
Contributor

@Ocre42 Ocre42 commented Mar 8, 2019

Tackling Issue #539 of the dashboard, this PR changes comprehensiveness so it saves budget and budget-not-provided as different values. It also adds validation against the BudgetNotProvided codelist, ensuring that values in the @budget-not-provided attribute are part of said codelist.

@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage remained the same at 56.459% when pulling 2eec4d8 on validate-budget-not-provided into 5ad867e on master.

@samuele-mattiuzzo samuele-mattiuzzo merged commit e6bffcb into master Mar 14, 2019
@samuele-mattiuzzo samuele-mattiuzzo deleted the validate-budget-not-provided branch March 14, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants