Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests and document forwardlooking_budget_not_provided() #151

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Update tests and document forwardlooking_budget_not_provided() #151

merged 4 commits into from
Mar 22, 2019

Conversation

Ocre42
Copy link
Contributor

@Ocre42 Ocre42 commented Mar 15, 2019

Importing the functions from ActivityStats for tests, tackling #148

Investigating #150, _forwardlooking_is_current() and _forwardlooking_exclude_in_calculations() take into account the activity-dates, to make this clearer, I've added docs to the function explaining the link to excluded cases.

@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 56.374% when pulling e0f6ca7 on forwardlooking_bnp into 8735326 on master.

@Ocre42 Ocre42 merged commit 9df9019 into master Mar 22, 2019
@Ocre42 Ocre42 deleted the forwardlooking_bnp branch March 22, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sargentfrancesca sargentfrancesca sargentfrancesca approved these changes

@samuele-mattiuzzo samuele-mattiuzzo Awaiting requested review from samuele-mattiuzzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ocre42 @coveralls @sargentfrancesca