Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing humanitarian 5-digit sector code #156

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Add missing humanitarian 5-digit sector code #156

merged 1 commit into from
Apr 17, 2019

Conversation

andylolz
Copy link
Contributor

@andylolz andylolz commented Apr 8, 2019

5-digit sector code 74020 (Multi-hazard response preparedness) was added in Jan 2018, and presumably should count as a humanitarian sector code.

There’s a corresponding update to make to the dashboard narrative, where it says:

[…] the use of DAC 5-digit sector codes between 72010 to 74010 inclusive […]

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.374% when pulling e07167a on andylolz:missing-humanitarian-sector-code into 9df9019 on IATI:master.

PetyaKangalova
PetyaKangalova approved these changes Apr 16, 2019
View reviewed changes
Copy link

@PetyaKangalova PetyaKangalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding. This is indeed correct so approving the pull request with the correct code addition. @IATI/devs this requires merging and deploying. Please note that the same change will also need to be implemented in the Grand Bargain dashboard as well.

@Ocre42
Copy link
Contributor

Ocre42 commented Apr 17, 2019

I'll merge this and deploy on dev, then most likely deploy it into live next week. Thanks @andylolz

@Ocre42 Ocre42 merged commit 6022c2d into IATI:master Apr 17, 2019
@andylolz andylolz deleted the missing-humanitarian-sector-code branch April 17, 2019 09:34
@andylolz andylolz mentioned this pull request Apr 17, 2019
Merged
@andylolz
Copy link
Contributor Author

andylolz commented Apr 17, 2019 •
edited
Loading

Ace, thanks both. But please also note above:

There’s a corresponding update to make to the dashboard narrative, where it says:

[…] the use of DAC 5-digit sector codes between 72010 to 74010 inclusive […]

I’ve sent a pull request for this change (IATI/IATI-Dashboard#542).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetyaKangalova PetyaKangalova PetyaKangalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andylolz @coveralls @Ocre42 @PetyaKangalova