Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher listing page #30

Closed
3 tasks done
stevieflow opened this issue Mar 5, 2014 · 14 comments
Closed
3 tasks done

Publisher listing page #30

stevieflow opened this issue Mar 5, 2014 · 14 comments

Comments

@stevieflow
Copy link
Contributor

http://iatiregistry.org/publisher

  • For those that start with "The XYZ" alter listing so that they become "XYZ, The"
  • Add column for country HQ (publisher country) of the organisation
  • Exclude any publishers that have 0 files from the listing
@amercader
Copy link
Contributor

How to do it:

  1. Add a new h.normalize_publisher_name or similar helper function and call it from [1]
  2. The caveat here is that org objects on the template don't have all extra fields associated with the publisher like the country. The get_publisher_organization_type helper needs to be extended to something more generic and return the country field (publisher_country) as well. Once we have this is just a matter of rearranging the table.
  3. Add a {% if organization.packages > 0 %} after the {% for organization in organizations %} in the organizations_list.html snippet.

To add/modify helpers, check [3]

[1] https://github.com/okfn/ckanext-iati/blob/master/ckanext/iati/theme/templates/organization/snippets/organization_list.html#L23
[2] https://github.com/okfn/ckanext-iati/blob/master/ckanext/iati/helpers.py#L43
[3] https://github.com/okfn/ckanext-iati/blob/master/ckanext/iati/plugins.py#L377

@stevieflow
Copy link
Contributor Author

Hi @amercader - thanks

The list of countries / regions - is that content managed anywhere?

@stevieflow
Copy link
Contributor Author

Also - please rename the label "Country" in the table at http://iati2.staging.ckanhosted.com/publisher to "HQ country"

@amercader
Copy link
Contributor

@stevieflow

The list of countries / regions - is that content managed anywhere?

https://github.com/okfn/ckanext-iati/blob/master/ckanext/iati/countries.py

We can format it a bit nicer with line breaks if you want. If there are changes in it we need to reindex (which is fine, just need to be aware of it)

Changed the HQ Country header.

@stevieflow
Copy link
Contributor Author

Thanks

@Bjwebb - any chance to take a look at this list and compare with Country & Region codelists?

@stevieflow
Copy link
Contributor Author

@amercader thanks

Apologies - can we change HQ Country to Publisher Country, to fit with http://iati2.staging.ckanhosted.com/dataset ?

In terms of the country / region list - we have the latest codelists for these here:

http://iatistandard.org/codelists/Country/
(http://iatistandard.org/codelists/downloads/clv2/json/en/Country.json)

http://iatistandard.org/codelists/Region/
(http://iatistandard.org/codelists/downloads/clv2/json/en/Region.json)

It is feasible to work with these at all?

@amercader
Copy link
Contributor

In terms of the country / region list - we have the latest codelists for these here:

@stevieflow I guess you mean update our local list with these values and not pull the lists from the remote json files.
We could do that, but you will need to sort the casing if you don't want all countries upper case :)

@stevieflow
Copy link
Contributor Author

@amercader yes, good point. @Bjwebb - is there anything you can help with?

@Bjwebb
Copy link
Contributor

Bjwebb commented May 20, 2014

The plan is to recreate the IATI Country codelist from the actual ISO list at some point over the next few weeks. At this point the list will stop being all uppercase. Therefore, if possible, I think it's best to wait until I do this.

@stevieflow
Copy link
Contributor Author

In the meantime, I've updated the labels for Regions: #43

@stevieflow
Copy link
Contributor Author

@amercader as well as pulling in the updated country/region list , would you also be able to update the label on http://iati2.staging.ckanhosted.com/publisher from "Publisher Country" to "Publisher Country / Region"

Thanks

@amercader
Copy link
Contributor

@stevieflow It messes a bit the table columns, and it will be hard to get all the widths right

http://iati2.staging.ckanhosted.com/publisher

Can we settle on "Country / Region", as I think being in the publishers page and the first column being "Publisher" gives enough context.

@stevieflow
Copy link
Contributor Author

OK - final word - can we alter to "HQ Country/Region" ?

@amercader
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants