Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page button responsiveness #410

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Conversation

yung-coder
Copy link
Contributor

Fixes Issue

My PR closes #407

Changes proposed

What were you told to do ?

I was told to fix the responsiveness of the buttons of home page.

What did you do ?

I tried to fix the responsiveness by modifying break point which will make it responsive for maximum no of devices.

Check List (Check all the applicable boxes)

  • [✅] My code follows the code style of this project.
  • [✅] This PR does not contain plagiarized content.
  • [✅] The title and description of the PR is clear and explains the approach.

Screenshots

milaln-done

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
milan ✅ Ready (Inspect) Visit Preview Oct 8, 2022 at 3:37AM (UTC)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello contributor, thank you for opening a Pull Request 🎉.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out Tamal Das on Twitter.
Star ⭐ this repo to show us support.

Happy, Open Source!

@vercel vercel bot temporarily deployed to Preview October 7, 2022 17:26 Inactive
@yung-coder
Copy link
Contributor Author

Made the changes @iamtamal please review it and let me know if any required changes....

@vercel vercel bot temporarily deployed to Preview October 8, 2022 03:26 Inactive
@tamalCodes
Copy link
Member

No need to tag me, i get the notification anyways :)

@vercel vercel bot temporarily deployed to Preview October 8, 2022 03:37 Inactive
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

  • ⚒ Thankyou for working on the issue
  • ⭐ Do star the repo, to get updates on more issues !
  • 💚 Keep contributing to Opensource

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. area/logic This issue is related to a logic fix. 🟧 priority: high area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. labels Oct 8, 2022
@tamalCodes tamalCodes merged commit 1ef5245 into ngoworldcommunity:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. area/ui This issue is related to frontend/interface fix. 🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Page buttons are not responsive
2 participants