IBFE ex7 tiny fix

[sach1]

Removed code that was previously enclosed in {{ #if 0, #endif }}

Example now compiles & runs successfully.

[jenkinsbot1024]

Can one of the admins verify this patch?

[jenkinsbot1024]

Can one of the admins verify this patch?

[jenkinsbot1024]

Can one of the admins verify this patch?

[sach1]

Also want to point out that the PK1 stress function arguments keep switching between commits for all the IBFE examples (even in prior versions of main.cpp where tests were not yet set up)

It changes between this

void
upper_PK1_stress_function(
    TensorValue<double>& PP,
    const TensorValue<double>& FF,
    const libMesh::Point& /*X*/,
    const libMesh::Point& s,
    Elem* const /*elem*/,
    const vector<const vector<double>*>& /*var_data*/,
    const vector<const vector<VectorValue<double> >*>& /*grad_var_data*/,
    double /*time*/,
    void* /*ctx*/)

and

void
upper_PK1_stress_function(
    TensorValue<double>& PP,
    const TensorValue<double>& FF,
    const libMesh::Point& /*X*/,
    const libMesh::Point& s,
    Elem* const /*elem*/,
    const vector<NumericVector<double>*>& /*system_data*/,
    double /*time*/,
    void* /*ctx*/)

not sure if this is intentional and which one is 'recommended use' ...

[boyceg]

Yes there was a change, but the arguments should not be jumping back-and-forth. Let me know if this is not the case. The new interface (with var_data and grad_var_data) is meant to make it easier to use additional field variables in evaluating these kinds of functions, by pre-evaluating the function value or gradient of the extra variable at the location where the stress is being evaluated. The old interface (with system_data) just passed the full NumericVector to the stress function and left it up to the stress function to evaluate the field variable at the right place.

…

On Dec 10, 2017, at 4:06 AM, Shashank Acharya ***@***.***> wrote: Also want to point out that the PK1 stress function arguments keep switching between commits for all the IBFE examples (even in prior versions of main.cpp where tests were not yet set up) It changes between this void upper_PK1_stress_function( TensorValue<double>& PP, const TensorValue<double>& FF, const libMesh::Point& /*X*/, const libMesh::Point& s, Elem* const /*elem*/, const vector<const vector<double>*>& /*var_data*/, const vector<const vector<VectorValue<double> >*>& /*grad_var_data*/, double /*time*/, void* /*ctx*/) and void upper_PK1_stress_function( TensorValue<double>& PP, const TensorValue<double>& FF, const libMesh::Point& /*X*/, const libMesh::Point& s, Elem* const /*elem*/, const vector<NumericVector<double>*>& /*system_data*/, double /*time*/, void* /*ctx*/) not sure if this is intentional... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEL8CTwiflP_mbab-ELupL76HT6P0lTFks5s-58ogaJpZM4Q8aqC>.

[sach1]

Oh, I understand now. Thanks for the detailed explanation.

[boyceg]

Jenkins check this please.

[boyceg]

ok to test

[boyceg]

Jenkins check this please.

[boyceg]

Hmmmm, it looks like the compiler is just crashing on the new VM...

[boyceg]

retest this please

[boyceg]

Hmmm, Jenkins is having trouble with this branch. I am going to go ahead and merge since it only touches the example code.