Some initial files added to support RigidIBFE #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the latest commit ... |
Merging latest master with amneetb/RigidIBFE
Merging latest changes from master.
…to amneetb/RigidIBFE Merging with origin.
…ing method approach to IBFEMethod class
Merging master with MechanicalValve branch.
… for constrained part
…to amneetb/RigidIBFE Merging changes for Mobility.m in branch
Conflicts: ibtk/contrib/eigen/COPYING.MINPACK ibtk/contrib/muparser/Changes.txt ibtk/contrib/muparser/Install.txt ibtk/contrib/muparser/License.txt ibtk/contrib/muparser/include/muParser.h ibtk/contrib/muparser/include/muParserBase.h ibtk/contrib/muparser/include/muParserBytecode.h ibtk/contrib/muparser/include/muParserCallback.h ibtk/contrib/muparser/include/muParserDLL.h ibtk/contrib/muparser/include/muParserDef.h ibtk/contrib/muparser/include/muParserError.h ibtk/contrib/muparser/include/muParserFixes.h ibtk/contrib/muparser/include/muParserInt.h ibtk/contrib/muparser/include/muParserStack.h ibtk/contrib/muparser/include/muParserTemplateMagic.h ibtk/contrib/muparser/include/muParserTest.h ibtk/contrib/muparser/include/muParserToken.h ibtk/contrib/muparser/include/muParserTokenReader.h ibtk/contrib/muparser/src/muParser.cpp ibtk/contrib/muparser/src/muParserBase.cpp ibtk/contrib/muparser/src/muParserBytecode.cpp ibtk/contrib/muparser/src/muParserCallback.cpp ibtk/contrib/muparser/src/muParserDLL.cpp ibtk/contrib/muparser/src/muParserError.cpp ibtk/contrib/muparser/src/muParserInt.cpp ibtk/contrib/muparser/src/muParserTest.cpp ibtk/contrib/muparser/src/muParserTokenReader.cpp src/IB/IBFEMethod.cpp
…to amneetb/RigidIBFE Merging with master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few comments:
(1) Both the regular IBStrategy and the rigid IBStrategy should use the same spreadForce() and interpolateVelocity() functions. The rigid IBStrategy should not replicate this functionality. One possibility is to split IBStrategy into three parts:
IBStrategy - basic functions that know how to spread, interpolate, etc but not to compute forces
IBElasticStrategy - functions specific to computing elastic forces
IBRigidStrategy - functions specific to rigid-body motion
(2) The rigid IBFEMethod should either simply be IBFEMethod, or it should be a subclass of IBFEMethod.
(3) Class names should start with uppercase. Prefer the convention of names becoming more specific as you read them from left to right (e.g. IBRigidStrategy rather than RigidIBStrategy).