Skip to content

Commit

Permalink
JakeLin’s feedbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
tbaranes committed Apr 4, 2017
1 parent 7057c1f commit 40424d9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -16,7 +16,7 @@ All notable changes to this project will be documented in this file.
[#403](https://github.com/IBAnimatable/IBAnimatable/pull/403) by [@tbaranes](https://github.com/tbaranes)
- Make images of `AnimatableSlider` designable.
[#417](https://github.com/IBAnimatable/IBAnimatable/pull/417) by [@phimage](https://github.com/phimage)
- Add `RefreshControlDesignable` to make `UIRefreshControl` customization available in interface builder. Currently supported by `UITableViewController` and `UITableView`
- Add `RefreshControlDesignable` to make `UIRefreshControl` customization available in Interface Builder. Currently supported by `UITableViewController` and `UITableView`
[#418](https://github.com/IBAnimatable/IBAnimatable/pull/418) by [@phimage](https://github.com/phimage) and [#429](https://github.com/IBAnimatable/IBAnimatable/pull/429) by [@tbaranes](https://github.com/tbaranes)

#### Bugfixes
Expand Down
6 changes: 3 additions & 3 deletions IBAnimatableApp/RefreshControlTableViewController.swift
Expand Up @@ -12,7 +12,7 @@ public class RefreshControlTableViewController: AnimatableTableViewController {
super.viewDidLoad()

// Install action on refresh
self.refreshControl?.addTarget(self, action: #selector(refresh(_:)), for: .valueChanged)
refreshControl?.addTarget(self, action: #selector(refresh(_:)), for: .valueChanged)
}

public func refresh(_ refreshControl: UIRefreshControl) {
Expand Down Expand Up @@ -42,8 +42,8 @@ public class RefreshControlTableViewController: AnimatableTableViewController {
}
refreshControl.attributedTitle = NSAttributedString(string: "\(Int(time))", attributes: attributes )

DispatchQueue.main.after(1) { [weak self] in
self?.updateMessage(refreshControl: refreshControl, time: time - 1)
DispatchQueue.main.after(1) {
self.updateMessage(refreshControl: refreshControl, time: time - 1)
}
}

Expand Down
4 changes: 2 additions & 2 deletions IBAnimatableApp/RefreshControlTableViewViewController.swift
Expand Up @@ -56,8 +56,8 @@ public class RefreshControlTableViewViewController: AnimatableViewController {
}
refreshControl.attributedTitle = NSAttributedString(string: "\(Int(time))", attributes: attributes )

DispatchQueue.main.after(1) { [weak self] in
self?.updateMessage(refreshControl: refreshControl, time: time - 1)
DispatchQueue.main.after(1) {
self.updateMessage(refreshControl: refreshControl, time: time - 1)
}
}

Expand Down

0 comments on commit 40424d9

Please sign in to comment.