Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn transition animation doesn't work. π stuff #440

Closed
phimage opened this issue Apr 11, 2017 · 2 comments · Fixed by #441
Closed

Turn transition animation doesn't work. π stuff #440

phimage opened this issue Apr 11, 2017 · 2 comments · Fixed by #441
Labels
difficulty: easy type: bug
Milestone
4.0

Comments

@phimage
Copy link
Member

phimage commented Apr 11, 2017 •
edited
Loading

we have in TurnAnimator

rotate(angle: factor * -.pi * 2)
rotate(angle: factor * .pi * 2)

instead of

rotate(angle: factor * -.pi / 2)
rotate(angle: factor * .pi / 2)

Maybe when converting the deprecated M_PI_2 some mistake happen
I think other .pi must be checked
@tbaranes
Copy link
Member

Introduced in 10104cd

As you said, it seems that we have a few more like this one. Do you want to take care of them?

@tbaranes tbaranes added this to the 4.0 milestone Apr 11, 2017
@phimage
Copy link
Member Author

phimage commented Apr 11, 2017

Not for the moment, because I am not sure of animation result for Fold and Flip

tbaranes added a commit that referenced this issue Apr 11, 2017
@tbaranes
Fix M_PI_2 migration which was breaking transitions
4722ea6 
Close #440
@tbaranes tbaranes mentioned this issue Apr 11, 2017
Merged
@tbaranes tbaranes modified the milestones: 4.x, 4.0 Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy type: bug
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix M_PI_2 migration which was breaking transitions IBAnimatable/IBAnimatable
2 participants
@tbaranes @phimage