Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RotationDesignable #no-public-changes #476

Merged
merged 1 commit into from
May 16, 2017

Conversation

SD10
Copy link
Member

@SD10 SD10 commented May 10, 2017

Summary of Pull Request:

  • Adds tests for RotationDesignable conforming classes.

@IBAnimatableBot
Copy link

IBAnimatableBot commented May 10, 2017

2 Warnings
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ Consider adding / updating the demo ap.

Generated by 🚫 Danger


// MARK: - MockRotationDesignable

protocol MockRotationDesignable: class, RotationDesignable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need these mocks in others tests? For example, to test mixing designable properties. Won't be better to create a file by mock? (just wondering, up to you)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by creating a file by mock. Right now I'm testing each protocol and creating a mock for that protocol. One protocol per file.

As for testing mixing designable properties... basically, you're talking about one designable protocol affecting the performance of another designable protocol? That's an interesting point you bring up. I'm just testing the individual components right now... mixing them does add another degree of complexity.

Copy link
Member

@tbaranes tbaranes May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got my point. I think the main point to do mixing tests is your mock, it shouldn't be too complicated with your architecture (besides the complexity of the test itself). Saying that I'm wondering if we should put out each mock protocol (in their own files) to make easier to find them when we will start to work on mixing tests.

Since they are internal, it will work as expected, but it may be harder to find them in the project when we will need them in other context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're saying.
I know each file we add will add like 3-4 seconds on to the build time though!
I'm open to doing this but I think mixing tests is a little way down the road.
-- I started to write a long response regarding mixing tests... a lot going through my mind now. You just had to bring this up!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can continue this discussion when we will start mixing tests, for now, it's not blocking this PR!

@SD10 SD10 force-pushed the testing/rotation-designable branch from 73e9d4f to b0d178f Compare May 10, 2017 08:20
@SD10 SD10 force-pushed the testing/rotation-designable branch from b0d178f to 81df3d6 Compare May 16, 2017 01:25
@SD10 SD10 merged commit 85a85bb into master May 16, 2017
@SD10 SD10 deleted the testing/rotation-designable branch May 16, 2017 01:36
@SD10
Copy link
Member Author

SD10 commented May 18, 2017

#434 - marking this for record keeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants