-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded xcodeprojs in workspace #no-public-changes #484
Conversation
945ab63
to
9ef5d20
Compare
Generated by 馃毇 Danger |
@tbaranes you mean group each storyboard file with its respective view controller? I do it both ways depending on the project. I agree that grouping them together would significantly help when working with the demo app. I would vote yes for this change 馃憤 |
That what I mean! |
I just reordered xcodeproj groups (same as master), I think it's ready to go. My question about the storyboards organisation still here, but we can do it in a second a PR. If travis passes, and everything is ok with it, it's ok to go 馃挜 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤 I think we need to update the README.md as well. open IBAnimatable.xcworkspace
I prefer to group them by features. I don't know why I did it that way (separating storyboards and codes) |
First step for #479
IBAnimatable.xcworkspace
IBAnimatable.xcodeproj
(framework)IBAnimatableApp.xcodeproj
(demo / playground). In a long term process, I'm even wondering if we shouldn't make two demos: one for the full demo, and a second one for playgroundsSources
One question: I know that, from the beginning, we separate storyboards and codes in the demo app. I'm personally a huge fan of this pattern because I find it hard to navigate, and find back the related files. What do you guys prefers about this? If you are ok to group them, I can update the PR.
I'm targeting master because it doesn't introduce any breaking changes, only internal restructuration, but it will be very hard to rebase any PRs due to these changes 馃槵