When device orientation change reset the modal dialog context frame Fix #515 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
JakeLin
approved these changes
Oct 13, 2017
| @@ -179,4 +179,10 @@ open class AnimatableModalViewController: UIViewController, PresentationDesignab | |||
| super.viewDidAppear(animated) | |||
| configureDismissalTransition() | |||
| } | |||
|
|
|||
| open override func viewDidLayoutSubviews() { | |||
There was a problem hiding this comment.
I think that's safe to use viewDidLayoutSubviews, it will update the UI when any UI has been changed. Another way would be viewWillTransitionToSize:withTransitionCoordinator: for size class. But I think viewDidLayoutSubviews is fine.
Remove trailing whitespace
tbaranes
approved these changes
Oct 14, 2017
| @@ -103,12 +103,17 @@ public extension PresentationDesignable where Self: UIViewController { | |||
| } | |||
| } | |||
|
|
|||
| public func configurePresenterFrameForPresentation() { | |||
| presenter?.presentationConfiguration?.contextFrameForPresentation = contextFrameForPresentation?() | |||
| print("presenter \( presenter?.presentationConfiguration?.contextFrameForPresentation)") | |||
There was a problem hiding this comment.
oups, I forgot to remove this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure that this is the best solution but I try to fix it.
To detect device orientation change I override
AnimatableModalViewController. viewDidLayoutSubviewsWhen device orientation change I call the same code launched when updating
AnimatableModalViewController.contextFrameForPresentation(I make a method for that
configurePresenterFrameForPresentation)But how to update the frame without knowing the source, the segue, the parent view, ...?
I replace
contextFrameForPresentationtype fromCGRectto closure to execute exactly the same code inPresentOverCurrentContextSegueMaybe we can do better, find element in view hierarchy, make constraint, ...?
Then I see an issue, updating the
contextFrameForPresentationin thepresenter(configurePresenterFrameForPresentation) do nothing.And I understand why. The
PresentationConfigurationpassed to the presentation controller is astruct, so a copy and no update in presentation controller.By changing type to
class, the object is shared.