Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AnimatableModalViewController._dismissalAnimationType #526

Merged
merged 2 commits into from
Jan 4, 2018
Merged

fix AnimatableModalViewController._dismissalAnimationType #526

merged 2 commits into from
Jan 4, 2018

Conversation

kazyk
Copy link
Contributor

@kazyk kazyk commented Jan 4, 2018

Fixed an issue of setting dismissal animation type from IB.

JakeLin
JakeLin approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@JakeLin
Copy link
Member

JakeLin commented Jan 4, 2018

@kazyk thanks for fixing that, can you please add an item to CHANGELOG.md as well?

@kazyk
Copy link
Contributor Author

kazyk commented Jan 4, 2018

@JakeLin
done 👍

@JakeLin JakeLin merged commit fef0a7b into IBAnimatable:master Jan 4, 2018
@JakeLin
Copy link
Member

JakeLin commented Jan 4, 2018

@kazyk thanks, it is merged. Thanks to @tbaranes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeLin JakeLin JakeLin approved these changes

@tbaranes tbaranes tbaranes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kazyk @JakeLin @tbaranes