Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MaskDesignable support to IB #no-public-changes #536

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Add MaskDesignable support to IB #no-public-changes #536

merged 1 commit into from
Feb 6, 2018

Conversation

tbaranes
Copy link
Member

@tbaranes tbaranes commented Feb 5, 2018

Related to #528

@tbaranes tbaranes mentioned this pull request Feb 5, 2018
Open
@IBAnimatableBot
Copy link

IBAnimatableBot commented Feb 5, 2018 •
edited

2 Warnings
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ Consider adding / updating the demo app.

SwiftLint found issues

Warnings

File Line Reason
MaskDesignable.swift 36 Limit vertical whitespace to a single empty line. Currently 2.

Generated by 🚫 Danger

JakeLin
JakeLin approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sources/Protocols/Designable/MaskDesignable.swift
}
}

private func removePreviousMask(_ previousMaskType: MaskType, in view: UIView) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tbaranes tbaranes merged commit b565f27 into master Feb 6, 2018
@tbaranes tbaranes deleted the feature/ib_maskdesignable branch February 6, 2018 07:23
@tbaranes tbaranes restored the feature/ib_maskdesignable branch February 6, 2018 07:23
@tbaranes tbaranes deleted the feature/ib_maskdesignable branch February 6, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeLin JakeLin JakeLin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbaranes @IBAnimatableBot @JakeLin