Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get converted CACurrentMediaTime from layer. #541

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

lukas2
Copy link
Contributor

@lukas2 lukas2 commented Mar 10, 2018

PR for #540

@IBAnimatableBot
Copy link

IBAnimatableBot commented Mar 10, 2018

2 Warnings
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.
⚠️ Consider adding / updating the demo app.

SwiftLint found issues

Warnings

File Line Reason
ActivityIndicatorAnimationBallScaleMultiple.swift 23 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallScaleMultiple.swift 24 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallScaleMultiple.swift 25 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallScaleRippleMultiple.swift 24 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallScaleRippleMultiple.swift 25 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallScaleRippleMultiple.swift 26 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallSpinFadeLoader.swift 28 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallSpinFadeLoader.swift 29 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallSpinFadeLoader.swift 30 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationBallSpinFadeLoader.swift 31 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationLineSpinFadeLoader.swift 28 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationLineSpinFadeLoader.swift 29 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationLineSpinFadeLoader.swift 30 Function parameters should be aligned vertically if they're in multiple lines in a method call.
ActivityIndicatorAnimationLineSpinFadeLoader.swift 31 Function parameters should be aligned vertically if they're in multiple lines in a method call.
Animatable.swift 635 Function parameters should be aligned vertically if they're in multiple lines in a method call.
Animatable.swift 668 Function parameters should be aligned vertically if they're in multiple lines in a method call.
Animatable.swift 689 Function parameters should be aligned vertically if they're in multiple lines in a method call.
Animatable.swift 153 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 166 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 178 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 239 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 267 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 515 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 535 Functions and methods parameters should be either on the same line, or one per line.
Animatable.swift 557 Functions and methods parameters should be either on the same line, or one per line.

Generated by 🚫 Danger

Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for fixing this issue.

Copy link
Member

@tbaranes tbaranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Can you just add an entry to the changelog?

@lukas2
Copy link
Contributor Author

lukas2 commented Mar 12, 2018

Thanks for approving and all your work on this lib! 🙇‍♂️

Updated changelog. Do I have to create a new PR or can you merge it as it is? It shows up here, so I think it should work. (Github newbie here.. heh)

@JakeLin JakeLin merged commit aa65f0a into IBAnimatable:master Mar 12, 2018
@JakeLin
Copy link
Member

JakeLin commented Mar 12, 2018

@lukas2 thanks again for updating the CHANGELOG.md. It is merged now 🎉. Thanks to @tbaranes for reviewing it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants