Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to support Swift 4.1 #no-public-changes #557

Merged
merged 5 commits into from
Apr 21, 2018
Merged

Upgrade to support Swift 4.1 #no-public-changes #557

merged 5 commits into from
Apr 21, 2018

Conversation

JakeLin
Copy link
Member

@JakeLin JakeLin commented Apr 20, 2018

Upgrade to support Swift 4.1 and Xcode 9.3 (9E145). Related to #555

phimage
phimage approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@phimage phimage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more warning 👍

@IBAnimatableBot
Copy link

IBAnimatableBot commented Apr 20, 2018 •
edited
Loading

1 Warning
⚠️ Consider adding supporting documentation to this change. Documentation can be found in the docs directory.

Generated by 🚫 Danger

@JakeLin JakeLin changed the title Upgrade to support Swift 4.1 Upgrade to support Swift 4.1 #no-public-changes Apr 20, 2018
tbaranes
tbaranes approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@tbaranes tbaranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice move 😀

@phimage
Copy link
Member

phimage commented Apr 20, 2018

CHANGELOG.md 👿

@SD10
Copy link
Member

SD10 commented Apr 20, 2018

Yeah CHANGELOG entry wouldn’t hurt even if no public changes. I’ve had quite a bit of trouble with Swift 4.1 on other libraries

Sent with GitHawk

@JakeLin JakeLin merged commit cd297cc into master Apr 21, 2018
@JakeLin JakeLin deleted the feature/upgrade-to-swift-4.1 branch April 21, 2018 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbaranes tbaranes tbaranes approved these changes

@phimage phimage phimage approved these changes

@SD10 SD10 Awaiting requested review from SD10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JakeLin @IBAnimatableBot @phimage @SD10 @tbaranes