Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a first version of mask customisation from IB following the related threads. Should closed #8 #50 #76
The following implementation has been done for:
StarMask
, IB usage:Star(6)
,Star(12)
...WaveMask
, IB usage:Wave(up,50,100)
If one parameters is missing, or miswrite, we will fall back to the basic implementation with default values.
I also allowed some miswrite errors:
Star(6
is accepted, as well asWave(up, 50, 100)
Finally, I didn't implement the swifty enum. I concluded that we will still need a string enum in order to avoid hard coding strings or multiple constants for each mask. So, even if it's more swifty to have the following one, it will just create duplicates code.
Missing:
I'm waiting your feedbacks on that :)