Re #142: Swap out assertions for early return

This prevents warnings when we're already checking the values, presumably because of race conditions.
IBBoard · Aug 27, 2020 · 77fb1e1 · 77fb1e1
1 parent 0888790
commit 77fb1e1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/CbMediaDownloader.c b/src/CbMediaDownloader.c
@@ -516,10 +516,12 @@ cb_media_downloader_load_hires_async (CbMediaDownloader   *downloader,
 
   g_return_if_fail (CB_IS_MEDIA_DOWNLOADER (downloader));
   g_return_if_fail (CB_IS_MEDIA (media));
-  g_return_if_fail (!media->loaded_hires);
-  g_return_if_fail (!media->loading_hires);
   g_return_if_fail (media->surface_hires == NULL);
 
+  if (media->loading_hires || media->loaded_hires) {
+    return;
+  }
+
   media->loading_hires = TRUE;
   task = g_task_new (downloader, downloader->cancellable, callback, user_data);
   data = g_new0 (LoadingData, 1);