Add support validating placeholder and viewController module #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
approved these changes
Sep 12, 2019
| let okUrl = fixture.path("Resources/Rules/CustomModuleRule/CustomModuleOKTest.xib") | ||
| let okViolations = try! rule.validate(xib: XibFile(url: okUrl)) | ||
| XCTAssertEqual(okViolations.count, 0) | ||
| let storyboardNgUrl = fixture.path("Resources/Rules/CustomModuleRule/CustomModuleNGTest.storyboard") |
There was a problem hiding this comment.
I think abbreviations is named in capital cases in commonly Swift style guide.
| let okUrl = fixture.path("Resources/Rules/CustomModuleRule/CustomModuleOKTest.xib") | ||
| let okViolations = try! rule.validate(xib: XibFile(url: okUrl)) | ||
| XCTAssertEqual(okViolations.count, 0) | ||
| let storyboardNgUrl = fixture.path("Resources/Rules/CustomModuleRule/CustomModuleNGTest.storyboard") | ||
| let storyboardNgViolations = try! rule.validate(storyboard: StoryboardFile(url: storyboardNgUrl)) |
|
@giginet Thank you for your review!. I fixed the points. |
|
@rb-de0 Sorry also about |
|
I'll add small fixes after merging. Thanks!!! |
|
I'll release newer version soon |
Merged
|
@rb-de0 Sorry for waiting you. I released 0.4.17 onto Homebrew/CocoaPods 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support validating module of a placeholder or viewController.
Currently we are using this tool, but I think we need to validate module in a placeholder or a ViewController.
This PR also update the related tests.