Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and bump up version to 0.4.16 #97

Merged
merged 6 commits into from
Apr 17, 2019

Conversation

giginet
Copy link
Member

@giginet giginet commented Apr 16, 2019

I hit this issue.
Remove IBIdentifiable conformance from ViewProtocol by kateinoigakukun · Pull Request #55 · IBDecodable/IBDecodable

So I updated some dependencies and bump up version to 0.4.16.

@@ -22,7 +22,7 @@ let package = Package(
],
dependencies: [
.package(url: "https://github.com/IBDecodable/IBDecodable.git", .branch("master")),
.package(url: "https://github.com/Carthage/Commandant.git", from: "0.15.0"),
.package(url: "https://github.com/Carthage/Commandant.git", .upToNextMinor(from: "0.16.0")),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Commandant 0.17.0, antitypical/Result is replaced to stdlib's.
Carthage/Commandant#150

So I pinned version to 0.16.x at this point.

Copy link
Collaborator

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@kateinoigakukun kateinoigakukun merged commit 7dc3269 into IBDecodable:master Apr 17, 2019
@giginet giginet deleted the 0.4.16 branch April 17, 2019 05:41
@giginet
Copy link
Member Author

giginet commented Apr 17, 2019

Thanks 😄

I'll cut a new release!

@giginet
Copy link
Member Author

giginet commented Apr 17, 2019

after merging #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants