Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Sample page doesn't render without internet connection #1212

Closed
2 tasks
Jakeeyturner opened this issue Aug 2, 2019 · 0 comments · Fixed by #1349
Closed
2 tasks

Sample page doesn't render without internet connection #1212

Jakeeyturner opened this issue Aug 2, 2019 · 0 comments · Fixed by #1349
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@Jakeeyturner
Copy link
Contributor

Description

When a user selects a sample, the webview will fail to render if they have no internet connection. This is because we attempt to fetch the samples README.

const response: any = await Axios.get(options.sample.readme);

Expected Behavior

We should either throw an error after a certain timeout value, or we should render the page without the README and let the user know we were unable to retrieve it.

Actual Behavior

Sample webview fails to render.

Possible Fix

On the Axios.get() request, we could pass a timeout value as one of the options.

Steps to Reproduce

  1. Open up Home page
  2. Disconnect from internet
  3. Click on FabCar or Commercial Paper sample

Existing issues

Log File

Your Environment

  • IBM Blockchain Platform Extension Version:
  • Visual Studio Code version:
  • Environment name and version (e.g. Node.js v8.12.0, npm v6.4.1):
  • Operating System and version:
  • Link to your project:
@Jakeeyturner Jakeeyturner added bug Something isn't working good first issue Good for newcomers labels Aug 2, 2019
@cazfletch cazfletch added this to the Sprint 14 milestone Aug 15, 2019
@au-shah au-shah self-assigned this Aug 24, 2019
@cazfletch cazfletch modified the milestones: Sprint 14, Sprint 15 Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants