Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Cancelling selecting environment files creates an environment I can connect to #1390

Closed
heatherlp opened this issue Sep 11, 2019 · 1 comment · Fixed by #1414
Closed

Cancelling selecting environment files creates an environment I can connect to #1390

heatherlp opened this issue Sep 11, 2019 · 1 comment · Fixed by #1414
Assignees
Labels
bug Something isn't working sev3
Milestone

Comments

@heatherlp
Copy link
Contributor

heatherlp commented Sep 11, 2019

Description

When cancelling the dialog box for selecting node JSON files for creating an environment, the environment is created anyway.
I see message: Added a new environment, but some nodes could not be added
and if I click on it, I can connect, despite giving no file

Expected Behavior

I think the action should be cancelled and no environment created
Correct behaviour is seen on Create Gateway command

Actual Behavior

Explained above

Possible Fix

Handle the "Cancel" return value from the dialog box properly

Steps to Reproduce

  1. Create an environment, give a name
  2. Cancel selecting a node file

Extension version: 1.0.10 test version

@heatherlp heatherlp added the bug Something isn't working label Sep 11, 2019
@cazfletch cazfletch added the sev3 label Sep 11, 2019
@cazfletch cazfletch added this to the Sprint 16 milestone Sep 11, 2019
@Jakeeyturner
Copy link
Contributor

@erin-hughes is assigned to this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working sev3
Projects
None yet
4 participants