Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n properties files with JAVA* types should omit .properties from bundle name on GP #126

Closed
jugu opened this issue Jan 4, 2019 · 0 comments

Comments

@jugu
Copy link
Contributor

jugu commented Jan 4, 2019

When using resource filter using JAVAMSG or JAVAMSGUTF8 as file type during upload for java properties files, then the bundle names are created .properties extension.
The behaviour should be consistent for java types which includes JAVA, JAVAUTF8, JAVAMSG, and JAVAMSGUTF8.

May need to introduce change at: https://github.com/IBM-Cloud/gp-java-tools/blob/master/gp-res-filter/src/main/java/com/ibm/g11n/pipeline/resfilter/impl/DefaultResourceFilterProvider.java#L141

yumaoka added a commit to yumaoka/gp-java-tools that referenced this issue Jan 4, 2019
JAVAMSG/JAVAMSGUTF8 type in resource filter should be handled as java
types, and use the same bundle name - file path mapping logic with
JAVA/JAVAMSG types. Fixes IBM-Cloud#126.
yumaoka added a commit that referenced this issue Jan 4, 2019
JAVAMSG/JAVAMSGUTF8 type in resource filter should be handled as java
types, and use the same bundle name - file path mapping logic with
JAVA/JAVAMSG types. Fixes #126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant