Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write the flattened JSON each time so we can compare it #121

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Jul 10, 2018

this adds an output.json file written every time the test runs. It's sorted, so it should NOT change in contents on a run.

This way i have something to test interoperability with IBM-Cloud/gp-js-flatten#18

@srl295 srl295 self-assigned this Jul 10, 2018
@coveralls
Copy link

coveralls commented Jul 10, 2018

Coverage Status

Coverage remained the same at 50.557% when pulling 3de70e8 on srl295:flatten-interchange into aff9a2e on IBM-Cloud:master.

Copy link
Contributor

@jugu jugu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srl295 srl295 merged commit ac6bc0b into IBM-Cloud:master Jul 10, 2018
@srl295 srl295 deleted the flatten-interchange branch July 10, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants