Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using double single quote in message format #133

Merged
merged 1 commit into from
Feb 5, 2019
Merged

using double single quote in message format #133

merged 1 commit into from
Feb 5, 2019

Conversation

jugu
Copy link
Contributor

@jugu jugu commented Feb 5, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 50.96% when pulling ceced01 on jugu:master into 49d608b on IBM-Cloud:master.

yumaoka
yumaoka approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@yumaoka yumaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.
We will need to define the behavior for some edge cases, and require some extra mechanism to support full roundtrip. But this is something we can do quickly for now.

@yumaoka yumaoka merged commit f05b1e6 into IBM-Cloud:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumaoka yumaoka yumaoka approved these changes

@RollinJin RollinJin Awaiting requested review from RollinJin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jugu @coveralls @yumaoka