Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request -> bent #168

Merged
merged 1 commit into from
Jul 10, 2019
Merged

request -> bent #168

merged 1 commit into from
Jul 10, 2019

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Jul 9, 2019

  • remove last usages of 'request' in favor of 'bent' (which is already a dependency
    due to IAM)
  • cleanup more async test stuff

@srl295
request -> bent
a47b15a 
- remove last usages of 'request' in favor of 'bent' (which is already a dependency
due to IAM)
- cleanup more async test stuff
@srl295 srl295 requested review from JCEmmons and sid41 July 9, 2019 00:21
@srl295 srl295 self-assigned this Jul 9, 2019
@srl295 srl295 added the test label Jul 9, 2019
@srl295
Copy link
Contributor Author

srl295 commented Jul 9, 2019

tests will be easier to read when something fails (such as a 404)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.192% when pulling a47b15a on bentify into 479a9d5 on master.

sid4
sid4 approved these changes Jul 9, 2019
View reviewed changes
Copy link

@sid4 sid4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sid41
sid41 approved these changes Jul 9, 2019
View reviewed changes
Copy link

@sid41 sid41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srl295 srl295 merged commit 9fc2662 into master Jul 10, 2019
@srl295 srl295 deleted the bentify branch July 10, 2019 00:05
@srl295 srl295 mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid4 sid4 sid4 approved these changes

@sid41 sid41 sid41 approved these changes

@JCEmmons JCEmmons Awaiting requested review from JCEmmons

Assignees

@srl295 srl295

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srl295 @coveralls @sid4 @sid41