Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a linter and use it #19

Merged
merged 2 commits into from
Jul 10, 2018
Merged

add a linter and use it #19

merged 2 commits into from
Jul 10, 2018

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Jul 10, 2018

use eslint

@srl295 srl295 self-assigned this Jul 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 984a7ad on srl295:lint into 83ad1a2 on IBM-Cloud:master.

jugu
jugu approved these changes Jul 10, 2018
View reviewed changes
Copy link

@jugu jugu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srl295 srl295 merged commit af4cd53 into IBM-Cloud:master Jul 10, 2018
@srl295 srl295 deleted the lint branch July 10, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jugu jugu jugu approved these changes

@pgaglani1 pgaglani1 Awaiting requested review from pgaglani1

@yumaoka yumaoka Awaiting requested review from yumaoka

Assignees

@srl295 srl295

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srl295 @coveralls @jugu