Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conform to gp-java-tools flattening #20

Merged
merged 8 commits into from
Jul 13, 2018
Merged

conform to gp-java-tools flattening #20

merged 8 commits into from
Jul 13, 2018

Conversation

srl295
Copy link
Contributor

@srl295 srl295 commented Jul 10, 2018 •
edited
Loading

Fixes: #18 ( use single quote)
Fixes: #9 (arrays)

also fixes security vuln in dependencies.

@srl295 srl295 added the bug label Jul 10, 2018
@srl295 srl295 self-assigned this Jul 10, 2018
@srl295 srl295 requested review from jugu and yumaoka July 10, 2018 23:32
@coveralls
Copy link

coveralls commented Jul 10, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e2f203e on srl295:conformity into af4cd53 on IBM-Cloud:master.

pgaglani1
pgaglani1 approved these changes Jul 13, 2018
View reviewed changes
Copy link

@pgaglani1 pgaglani1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srl295

@srl295 srl295 merged commit 2e29221 into IBM-Cloud:master Jul 13, 2018
@srl295 srl295 deleted the conformity branch July 13, 2018 16:31
@srl295 srl295 mentioned this pull request Apr 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgaglani1 pgaglani1 pgaglani1 approved these changes

@jugu jugu Awaiting requested review from jugu

@yumaoka yumaoka Awaiting requested review from yumaoka

@JCEmmons JCEmmons Awaiting requested review from JCEmmons

Assignees

@srl295 srl295

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use single quote for long format syntax Improve array support
3 participants
@srl295 @coveralls @pgaglani1