This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Fix login flow, and add mock API responses #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated dashboard saga tests to properly fail if state is not as expected, therefore causing the calls to send null values.
|
LGTM |
|
Did you mean to close it without merging? |
l2fprod
added a commit
that referenced
this pull request
Sep 5, 2016
* ignore node_modules across build stages * Global theme reference (#20) * Copy most project config to storybook webpack this fixes a few things… * Add a way to reference global theme colors as variables * adding jsdom as dev dependency - ava.config.js depends on it and when running in the build pipeline it is not found. IBM-Cloud/logistics-wizard#190 * Fix errors in test (#23) Also fixed all lint errors and warnings * inject the controller service url during the build phase * use a valid but non existent url * append /api/v1 to controller url * move manifest to dist to reduce the size of the artifacts directory in the build pipeline - to speed up the build * inject a __CONTROLLER_API__ variable through the config globals - similar capability as the transform env var modules #17 * path = . is the default, removing it. #17 * trying node v5 to circumvent --harmony-proxies issue. #17 * propagate CONTROLLER_API to unit test #17 * Add some config for Travis and Coveralls (#26) * Add some config for Travis and Coveralls * Updated node version in travis.yml * Tests now auto assign global from config * document CONTROLLER_API in globals * Fix login flow, and add mock API responses (#29) * Began writing tests for Dashboard module * Add mock api * Fixed login flow to call userid, not demo id Also updated dashboard saga tests to properly fail if state is not as expected, therefore causing the calls to send null values. closes #21
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21
The previous login saga was using the demo ID, instead of the userid.
When updating the code, I realized I didn't have a way for the saga tests to fail if the State changes from what I expected it to be when I wrote the tests...so I now use reducers and mock api responses to more accurately represent what is happening (and mostly have the tests fail properly)