This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'__CONTROLLER_API__' : config.env === 'test' ? | ||
`${config.controller_service}/api/v1` : | ||
JSON.stringify(`${config.controller_service}/api/v1`), | ||
'__CONTROLLER_API__' : JSON.stringify(config.controller_service || ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the removal of /api/v1 here means we will need to update the toolchain and the live pipeline. It currently only passes the host.domain part. Goal was to be able to have multiple API version and let the client - in this case the webui the choice to use v1 or v2, etc. If you want to stick to full host.domain/path make sure to update logistics-wizard-toolchain and the live pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Let me update it.
Also refactored to be a bit simpler.
Couple of tests added RoleItem made a bit simpler to use WIP - Began wrapping RoleSwitcher with state context
WIP converting demo session retrieval and login to demos module and kicking it off on route change, not from the dashboard component itself.
Login success now updates logged in user and stores token updated mock apis to be more flexible added mock APIs to some reducers on demo reducer tests
Cannot create a new manager yet, no UI built. Can switch roles though.
Learned a lot, changes look good to me - no comments. |
7f00770
to
27a28ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses story #2 and task #5
Still need to:
Hooking this up took a bit of refactoring.
The dashboard page currently doesn't call the getAdminData. I'll hook that up next to a real lifecycle or action.
Here is what everything looks like:
![screen recording 2016-09-08 at 04 48 pm](https://cloud.githubusercontent.com/assets/8884298/18371523/8d6ef1f0-75fa-11e6-812d-cfc0ad53b272.gif)
Other changes in this PR
Demo Data Flow
Mock API / stronger saga tests
What this allows, is for saga tests to properly fail if things change in the way data is passed around and modified (whereas before, we just generated made up objects and so it worked in test, but not in the running app)
The Saga tests look a bit more confusing, but are WAY more solid now. Writing and testing complex async actions has never been fun, but this makes them accurate and stable, which is the real win.