fix: Event Streams: do not return error when topic exists in creation #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please update testcase results |
hkantare
reviewed
Oct 26, 2021
| @@ -123,7 +134,20 @@ func resourceIBMEventStreamsTopicCreate(d *schema.ResourceData, meta interface{} | |||
| } | |||
| err = adminClient.CreateTopic(topicName, &topicDetail, false) | |||
| if err != nil { | |||
| log.Printf("[DEBUG] resourceIBMEventStreamsTopicCreate CreateTopic err %s", err) | |||
| if kafkaErr, ok := err.(*sarama.TopicError); ok { | |||
| if kafkaErr.Err == sarama.ErrTopicAlreadyExists { | |||
There was a problem hiding this comment.
Add if kafkaErr != nil && kafkaErr.Err == sarama.ErrTopicAlreadyExists (to eliminate crash )
|
@JunliWang any update on PR |
|
@JunliWang Do we have any update on this? |
|
@JunliWang @hkantare Do we have any update on this. This is something that breaks at random when building our cluster through terraform and creates a lot of manual work in order to correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when terraform state is out of sync with topic state, error could happen when re-apply the configuration.
#2275