Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IKEPolicy and IPSecPolicy encryption/authentication #3530

Merged
merged 1 commit into from Jan 31, 2022
Merged

Update IKEPolicy and IPSecPolicy encryption/authentication #3530

merged 1 commit into from Jan 31, 2022

Conversation

ChaseRun
Copy link
Collaborator

@ChaseRun ChaseRun commented Jan 27, 2022 •
edited

  • IKEPolicy
    • Removed des-cbc encryption
    • Updated docs
  • IPSecPolicy
    • Removed des-cbc encryption
    • Updated docs

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIIKEPolicyBasic
--- PASS: TestAccIBMPIIKEPolicyBasic (53.10s)
=== RUN   TestAccIBMPIIPSecPolicyBasic
--- PASS: TestAccIBMPIIPSecPolicyBasic (28.76s)

Updated IKEPolicy and IPSecPolicy
b292268 
 - IKEPolicy
   - Removed des-cbc encryption
   - Updated docs
 - IPSecPolicy
   - Removed des-cbc encryption
   - Removed sha-384, sha-256, and sha1 authentication. Added hmac-sha-256-128 and hmac-sha1-96
   - Updated tests
   - Updated docs
@ChaseRun ChaseRun requested review from yussufsh and kavya498 and removed request for yussufsh January 27, 2022 15:30
@ChaseRun ChaseRun added the service/Power Systems Issues related to Power Systems label Jan 27, 2022
yussufsh
yussufsh approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hkantare hkantare merged commit da50919 into IBM-Cloud:master Jan 31, 2022
@ChaseRun ChaseRun deleted the encryption-change branch February 15, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare hkantare approved these changes

@kavya498 kavya498 Awaiting requested review from kavya498

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChaseRun @yussufsh @hkantare