Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add network update support #3565

Merged
merged 1 commit into from Feb 11, 2022
Merged

add network update support #3565

merged 1 commit into from Feb 11, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

@dhirendersingh19 dhirendersingh19 commented Feb 9, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPINetworkDNSBasic
--- PASS: TestAccIBMPINetworkDNSBasic (127.91s)
PASS

@dhirendersingh19 dhirendersingh19 changed the title add network update support WIP: add network update support Feb 9, 2022
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Feb 10, 2022
@dhirendersingh19 dhirendersingh19 changed the title WIP: add network update support add network update support Feb 10, 2022
@dhirendersingh19 dhirendersingh19 changed the title add network update support WIP: add network update support Feb 10, 2022
@dhirendersingh19 dhirendersingh19 changed the title WIP: add network update support add network update support Feb 10, 2022
yussufsh
yussufsh approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkantare hkantare merged commit 64d65e8 into IBM-Cloud:master Feb 11, 2022
@dhirendersingh19 dhirendersingh19 deleted the network_dev branch February 11, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dhirendersingh19 @yussufsh @hkantare