Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert volume replication attribute in pi volume resource #4059

Merged
merged 3 commits into from Sep 26, 2022
Merged

Revert volume replication attribute in pi volume resource #4059

merged 3 commits into from Sep 26, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

@dhirendersingh19 dhirendersingh19 commented Sep 22, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
=== RUN   TestAccIBMPIVolumebasic
--- PASS: TestAccIBMPIVolumebasic (108.05s)
PASS
=== RUN   TestAccIBMPIVolumePool
--- PASS: TestAccIBMPIVolumePool (63.70s)
PASS
...

@dhirendersingh19 dhirendersingh19 added the service/Power Systems Issues related to Power Systems label Sep 22, 2022
@dhirendersingh19 dhirendersingh19 marked this pull request as ready for review September 22, 2022 06:53
@hkantare hkantare merged commit dcff4fb into IBM-Cloud:master Sep 26, 2022
hkantare pushed a commit that referenced this pull request Oct 3, 2022
@dhirendersingh19 @hkantare
Revert volume replication attribute in pi volume resource (#4059)
e362492 
* Add replication enabled attribute in volume resource

* Test case config refactored

* Revert "Add replication enabled attribute in volume resource"

This reverts commit 99896d6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare Awaiting requested review from hkantare

@yussufsh yussufsh Awaiting requested review from yussufsh

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhirendersingh19 @hkantare