feat(Cloud Databases): remove bluemix-go dependency for allowlist #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obai-1
reviewed
Dec 6, 2022
Comment on lines
+1573
to
1577
| if hasWhitelist { | ||
| ipAddresses = d.Get("whitelist").(*schema.Set) | ||
| } else { | ||
| ipAddresses = d.Get("allowlist").(*schema.Set) | ||
| } |
There was a problem hiding this comment.
Since we are moving on to allowlist should that get preference here?
ie,
if hasAllowlist {
ipAddresses = d.Get("allowlist").(*schema.Set)
} else {
ipAddresses = d.Get("whitelist").(*schema.Set)
}
There was a problem hiding this comment.
@obai-1 Only one will be set since these attributes conflict with each other
obai-1
reviewed
Dec 6, 2022
Comment on lines
+1884
to
1888
| if hasWhitelist { | ||
| d.Set("whitelist", flex.FlattenAllowlist(allowlist.IPAddresses)) | ||
| } else { | ||
| d.Set("allowlist", flex.FlattenAllowlist(allowlist.IPAddresses)) | ||
| } |
There was a problem hiding this comment.
obai-1
reviewed
Dec 6, 2022
Comment on lines
+2231
to
+2234
| if hasWhitelist { | ||
| _, entries = d.GetChange("whitelist") | ||
| } else if hasAllowlist { | ||
| _, entries = d.GetChange("allowlist") |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4220
This PR:
PUT /v5/ibm/deployments/{id}/allowlists/ip_addressesendpoint for setting allowlistsCommunity Note
Relates OR Closes #0000
Output from acceptance testing: