feat(Cloud Databases): Deprecate auto_scaling cpu attribute #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhemard
changed the title
alexhemard
force-pushed
the
alexhemard/autoscaling-fixes
branch
from
ef425b4
to
e2898ba
Compare
alexhemard
changed the title
alexhemard
force-pushed
the
alexhemard/autoscaling-fixes
branch
from
e2898ba
to
3d2e651
Compare
alexhemard
changed the title
alexhemard
force-pushed
the
alexhemard/autoscaling-fixes
branch
from
3d2e651
to
51908e3
Compare
obai-1
reviewed
Jun 5, 2023
| @@ -534,40 +534,6 @@ func DataSourceIBMDatabaseInstance() *schema.Resource { | |||
| }, | |||
| }, | |||
| }, | |||
| "cpu": { | |||
There was a problem hiding this comment.
Would this immediate removal cause any backward compatibility issues?
Better to add Deprecated in this block?
There was a problem hiding this comment.
I will mark it as deprecated - to be removed when auto_scaling cpu is removed from the ibm_database resource. Although, deprecating a data source attribute doesn't seem to give any message or warning
alexhemard
force-pushed
the
alexhemard/autoscaling-fixes
branch
from
51908e3
to
2d73262
Compare
obai-1
approved these changes
Jun 6, 2023
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates to: #4339
Deprecates
auto_scalingcpufrom theibm_databaseresource and data source, as this is not supported by Cloud Databases. This attribute will be removed in the future.Output from acceptance testing: