Modified TGW connection resource to support powerVS dependency… #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennburger
approved these changes
Jun 29, 2023
|
@sushmitha1506 Here are a few observations: There are two changes that are not related to PowerVS (one is in COS provider) - both of them have just an extra space. In |
|
There are two changes that are not related to PowerVS (one is in COS provider) - both of them have just an extra space.
|
hkantare
reviewed
Jul 11, 2023
added 4 commits
July 12, 2023 12:54
hkantare
approved these changes
Jul 13, 2023
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
…Cloud#4657) * feat: modified TGW connection resource to support powerVS dependency: None * feat: terrafrom support for powerVs connection dependency: None * feat: modified TGW connection resource to support powerVS dependency: None * feat: terrafrom support for powerVs connection dependency: None * feat: terrafrom support for powerVs connection dependency: None --------- Co-authored-by: sushmitha M <sushmitham@sushmithas-MacBook-Pro.local>
benbuchanan
pushed a commit
to benbuchanan/terraform-provider-ibm
that referenced
this pull request
Aug 17, 2023
…Cloud#4657) * feat: modified TGW connection resource to support powerVS dependency: None * feat: terrafrom support for powerVs connection dependency: None * feat: modified TGW connection resource to support powerVS dependency: None * feat: terrafrom support for powerVs connection dependency: None * feat: terrafrom support for powerVs connection dependency: None --------- Co-authored-by: sushmitha M <sushmitham@sushmithas-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Modified the TGW connection resource to support the new connection type PowerVS
Modified resource
resource "ibm_tg_connection"
Test Result
=== RUN TestAccIBMTransitGatewayConnection_basic
2023-06-28 20:52:41.236897 I | Inside testAccCheckIBMTransitGatewayConnectionExists :
--- PASS: TestAccIBMTransitGatewayConnection_basic (190.31s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/transitgateway 191.899s
Test-Result.pdf