fix(Cloud Databases): marshal blank string for latest PITR time #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhemard
force-pushed
the
latest-pitr-fix
branch
2 times, most recently
from
8b9fb64
to
32cffed
Compare
alexhemard
force-pushed
the
latest-pitr-fix
branch
from
32cffed
to
fbbceb1
Compare
obai-1
reviewed
Jul 27, 2023
| BackupID string `json:"backup-id,omitempty"` | ||
| RemoteLeaderID string `json:"remote_leader_id,omitempty"` | ||
| PITRDeploymentID string `json:"point_in_time_recovery_deployment_id,omitempty"` | ||
| PITRTimeStamp *string `json:"point_in_time_recovery_time,omitempty"` |
There was a problem hiding this comment.
Would this break backward compatibility?
There was a problem hiding this comment.
This is the struct that gets marshaled into JSON and is not a change to the schema
obai-1
approved these changes
Jul 27, 2023
Ak-sky
added a commit
to Ak-sky/terraform-provider-ibm
that referenced
this pull request
Aug 2, 2023
…me (IBM-Cloud#4718)" This reverts commit 35c0061.
benbuchanan
pushed a commit
to benbuchanan/terraform-provider-ibm
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #4651
The documentation suggests using a blank string for
point_in_time_recovery_time, but theomitemptyoption tag will not encode a blank string into JSON.point_in_time_recovery_timeto a pointer, addnil/ blank string checkingOutput from acceptance testing: