Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed(backup_policy_plan): delete_over_count null issue fixed #4735

Merged
merged 2 commits into from
Aug 4, 2023
Merged

fixed(backup_policy_plan): delete_over_count null issue fixed #4735

merged 2 commits into from
Aug 4, 2023

Conversation

ujjwal-ibm
Copy link
Contributor

@ujjwal-ibm ujjwal-ibm commented Aug 3, 2023 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #4734

Output from acceptance testing:

=== RUN   TestAccIBMIsBackupPolicyPlanCRC
no message sent
no message sent
--- PASS: TestAccIBMIsBackupPolicyPlanCRC (212.31s)
=== RUN   TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount
no message sent
no message sent
no message sent
--- PASS: TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount (202.16s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     420.000s

@ujjwal-ibm
Copy link
Contributor Author 

=== RUN   TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount
no message sent
no message sent
--- PASS: TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount (201.05s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     203.444s

@ujjwal-ibm
Copy link
Contributor Author 

=== RUN   TestAccIBMIsBackupPolicyPlanCRC
no message sent
no message sent
--- PASS: TestAccIBMIsBackupPolicyPlanCRC (212.31s)
=== RUN   TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount
no message sent
no message sent
no message sent
--- PASS: TestAccIBMIsBackupPolicyPlanCRCNullDeleteOverCount (202.16s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     420.000s

@hkantare hkantare merged commit 43d4909 into IBM-Cloud:master Aug 4, 2023
2 checks passed
benbuchanan pushed a commit to benbuchanan/terraform-provider-ibm that referenced this pull request Aug 17, 2023
@ujjwal-ibm @benbuchanan
fixed(backup_policy_plan): delete_over_count null issue fixed (IBM-Cl…
973d8dd 
…oud#4735)

* fixed(backup_policy_plan): delete_over_count null issue fixed

* added validation for delete over count [1-100] range
@ujjwal-ibm ujjwal-ibm deleted the null-delete-over-count branch October 30, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backup policy with null delete over count in remote region policies is throwing an error
2 participants
@ujjwal-ibm @hkantare