Adding support for COS Static Web hosting #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Sep 14, 2023
| } | ||
|
|
||
| if outputBucketWebsite != nil { | ||
| println("output is not nil") |
There was a problem hiding this comment.
Remove this kind of stmts
| @@ -91,6 +91,10 @@ func DataSourceIBMCosBucketObject() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Computed: true, | |||
| }, | |||
| "website_redirect": { | |||
| Type: schema.TypeString, | |||
| Optional: true, | |||
There was a problem hiding this comment.
in datasource its optional parmaeter
| @@ -120,6 +120,27 @@ data "ibm_cos_bucket" "object_lock_bucket" { | |||
|
|
|||
| ``` | |||
|
|
|||
|
|
|||
| # ibm_cos_bucket_website_configuration | |||
There was a problem hiding this comment.
Do we need a seperate example in ds since we don't have any specific arguments for static web
There was a problem hiding this comment.
We can keep an example to just let people know that the static webhosting is enabled , if not needed we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance testing :
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Basic (106.76s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 109.208s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Basic (85.53s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 87.162s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Index_Document_Only (85.16s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 86.551s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_With_Routing_Rules (93.82s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 95.500s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_With_Multiple_Routing_Rules (83.87s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 85.232s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Without_Public_Access (74.83s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 76.360s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Without_Public_Access (74.83s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 76.360s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Upload_Object_With_Redirect (84.16s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 85.631s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Empty_Config (68.45s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 70.028s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_Index_And_Redirect_Together (0.63s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 2.184s
--- PASS: TestAccIBMCosBucket_Website_Configuration_Bucket_No_Config (0.62s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 2.131s
Existing Test cases :
--- PASS: TestAccIBMCosBucket_Objectlock_Bucket_Enabled (102.15s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 103.910s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Without_Rule (107.24s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 108.964s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Valid_Mode_and_Days (102.76s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 104.278s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Valid_Mode_and_Years (101.39s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 103.337s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Without_Mode (0.55s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 2.236s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Empty (0.56s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 2.252s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_With_Mode_Only (75.71s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 77.448s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_With_Versioning_Not_Enabled (0.56s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 2.497s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Invalid_Mode (69.87s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 71.573s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Invalid_Days (72.86s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 74.739s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_ExistingBucket (24.54s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 27.006s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Updating_Objectlockrule_Years (40.85s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 42.807s
--- PASS: TestAccIBMCosBucket_Objectlock_Configuration_Updating_Objectlockrule_Days (38.20s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 39.932s
retention
--- PASS: TestAccIBMCOSBucketObjectlock_Retention_Without_Mode (44.47s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 46.163s
--- PASS: TestAccIBMCOSBucketObjectlock_Retention_Invalid_Mode (38.96s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 41.438s
--- PASS: TestAccIBMCOSBucketObjectlock_Retention_Retainuntildate_Past (33.60s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 35.893s
--- PASS: TestAccIBMCOSBucketObjectlock_Retention_Without_Retainuntildate (34.54s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 36.336s
--- PASS: TestAccIBMCOSBucketObjectlock_retention_without_objectlock_enabled (17.84s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 19.052s
--- PASS: TestAccIBMCOSBucketObjectlock_legalhold_without_objectlock_enabled (16.81s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 18.395s
--- PASS: TestAccIBMCOSBucketObject_basic (125.13s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 126.343s
--- PASS: TestAccIBMCosBucket_Basic (157.04s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 158.507s
--- PASS: TestAccIBMCosBucket_AllowedIP (171.19s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 172.893s
--- PASS: TestAccIBMCosBucket_ActivityTracker_Monitor (171.19s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 107.838s
--- PASS: TestAccIBMCosBucket_Archive_Expiration (243.26s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 244.642s
--- PASS: TestAccIBMCosBucket_Archive (194.66s)
--- PASS: TestAccIBMCosBucket_Expiredays (219.85s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cos 221.3