fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
…r authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Latest tests: $ make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy'
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 184.977s |
…r authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Latest tests: PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 210.150s |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Latest tests: PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 175.244s |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
kavya498
reviewed
Sep 22, 2023
| @@ -142,22 +229,22 @@ Review the argument references that you can specify for your resource. | |||
| - `roles` - (Required, list) The comma separated list of roles. For more information, about supported service specific roles, see [IAM roles and actions](https://cloud.ibm.com/docs/account?topic=account-iam-service-roles-actions) | |||
|
|
|||
| - `source_service_account` - (Optional, Forces new resource, string) The account GUID of source service.**Note** Conflicts with `subject_attributes`. | |||
| - `source_service_name` - (Required, Forces new resource, string) The source service name.**Note** Conflicts with `subject_attributes`. | |||
| - `target_service_name` - (Required, Forces new resource, string) The target service name.**Note** Conflicts with `resource_attributes`. | |||
| - `source_service_name` - (Optional, Forces new resource, string) The source service name.**Note** Conflicts with `subject_attributes`. | |||
There was a problem hiding this comment.
@swcolley, For all the arguments that you changed can you please add atleast one of them is required in the doc. It is misleading as all arguments are marked as optional.
Both in resource and datasource docs
There was a problem hiding this comment.
@kavya498 I pushed up changes, please let me know if that helps make it clearer.
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
…ssary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
kavya498
approved these changes
Sep 25, 2023
michaelkad
pushed a commit
to powervs-ibm/terraform-provider-ibm
that referenced
this pull request
Oct 4, 2023
update CHANGELOG Bump up version to 1.58.0-beta0 dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> Add IOPs to volume Add description and revert resource Update power-go-client version Fix typo Update go.mod documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1
manukm-ibm
added a commit
to manukm-ibm/terraform-provider-ibm
that referenced
this pull request
Oct 12, 2023
Add example for html Set account id from the token add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 update metadata update CHANGELOG Bump up version to 1.58.0-beta0 Update examples minor fixes dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 fmt fixes Region update Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
manukm-ibm
added a commit
to manukm-ibm/terraform-provider-ibm
that referenced
this pull request
Oct 12, 2023
author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118385 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697117979 +0530 Billing Snapshot Config APIs introduced in Usage Reports Add example for html Set account id from the token add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 update metadata update CHANGELOG Bump up version to 1.58.0-beta0 Update examples minor fixes dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 fmt fixes Region update Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix handling of bundle_certs in Secrets Manager public cert
manukm-ibm
added a commit
to manukm-ibm/terraform-provider-ibm
that referenced
this pull request
Oct 12, 2023
author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697119063 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118987 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118762 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118385 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697117979 +0530 Billing Snapshot Config APIs introduced in Usage Reports Add example for html Set account id from the token add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 update metadata update CHANGELOG Bump up version to 1.58.0-beta0 Update examples minor fixes dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 fmt fixes Region update Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix handling of bundle_certs in Secrets Manager public cert add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix handling of bundle_certs in Secrets Manager public cert
hkantare
pushed a commit
that referenced
this pull request
Oct 19, 2023
* parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697119063 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118987 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118762 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697118385 +0530 parent 0a7ebd9 author manu.k.m <manu.k.m@ibm.com> 1694802214 +0530 committer manu.k.m <manu.k.m@ibm.com> 1697117979 +0530 Billing Snapshot Config APIs introduced in Usage Reports Add example for html Set account id from the token add support for endpoint parameter in cluster_config (#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 update metadata update CHANGELOG Bump up version to 1.58.0-beta0 Update examples minor fixes dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> New CD Toolchains datasource (#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 fmt fixes Region update Get secret by name (#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> add support for endpoint parameter in cluster_config (#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <timothy.yao@ibm.com> Co-authored-by: Timothy-Yao <timothy.yao@ibm.com> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix handling of bundle_certs in Secrets Manager public cert add support for endpoint parameter in cluster_config (#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * re-ran fmt Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <shaun.colley@ibm.com> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <shaun.colley@ibm.com> --------- Signed-off-by: Shaun Colley <shaun.colley@ibm.com> Update bluemix-go (#4822) * update bluemix-go * update doc based on the latest changes Fix document category documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> --------- Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com> Fix for issue 4838 (#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <avir@il.ibm.com> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Fix handling of bundle_certs in Secrets Manager public cert * Add pagination to get snapshot list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes IAM/AM-issues/issues/1777
Output from acceptance testing:
Tested against test service. Waiting on COS to update service definition in staging environment to test against global catalog available service.
Update: Tested against COS, and tests passed. Results below.
$ make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy' PASS ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 98.144sUpdated tests with COS:
make testacc TESTARGS='-run=TestAccIBMIAMAuthorizationPolicy' ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/iampolicy 204.945s