Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

i4745 - add optional account id to kms config #4944

Merged
merged 2 commits into from Nov 23, 2023

Conversation

z0za
Copy link
Contributor

@z0za z0za commented Nov 22, 2023

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

#4745

Output from acceptance testing:

# using Account A's IBMCLOUD_API_KEY

=== RUN   TestAccIBMContainerVpcClusterBaseEnvvar

        resource "ibm_container_vpc_cluster" "cluster" {
                name              = "tf-vpc-cluster-62"
                vpc_id            = "<vpc_id_A>"
                flavor            = "bx2.4x16"
                worker_count      = 1
                resource_group_id = "<resourcegroup_id_A>"
                zones {
                        subnet_id = "<subnet_id_A>"
                        name      = "subnet-A"
                }
                wait_till = "normal"

                kms_config {
                        instance_id = "<kms_instance_id>"
                        crk_id = "<crk_id>"
                        account_id = "<account_id_A>"
                }

        }

--- PASS: TestAccIBMContainerVpcClusterBaseEnvvar (2586.88s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2589.275s

# using Account B's IBMCLOUD_API_KEY

=== RUN   TestAccIBMContainerVpcClusterBaseEnvvar

        resource "ibm_container_vpc_cluster" "cluster" {
                name              = "tf-vpc-cluster-33"
                vpc_id            = "<vpc_id_B>"
                flavor            = "bx2.4x16"
                worker_count      = 1
                resource_group_id = "<resourcegroup_id_B>"
                zones {
                        subnet_id = "<subnet_id_B>"
                        name      = "subnet-B"
                }
                wait_till = "normal"

                kms_config {
                        instance_id = "<kms_instance_id>"
                        crk_id = "<crk_id>"
                        account_id = "<account_id_A>"
                }

        }

--- PASS: TestAccIBMContainerVpcClusterBaseEnvvar (2429.93s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2431.625s


...

@z0za z0za changed the title I4745 kms i4745 - add optional account id to kms config Nov 23, 2023
@z0za z0za marked this pull request as ready for review November 23, 2023 08:44
@hkantare hkantare merged commit cc498ae into IBM-Cloud:master Nov 23, 2023
2 checks passed
@z0za z0za deleted the i4745_kms branch November 27, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants