Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Power VMRM #4994

Merged
merged 2 commits into from Feb 14, 2024
Merged

Add Power VMRM #4994

merged 2 commits into from Feb 14, 2024

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX’
=== RUN   TestAccIBMPIInstanceDeploymentTypeNoStorage
--- PASS: TestAccIBMPIInstanceDeploymentTypeNoStorage (482.04s)
PASS
...

@michaelkad michaelkad added the service/Power Systems Issues related to Power Systems label Dec 15, 2023
yussufsh
yussufsh requested changes Dec 15, 2023
View reviewed changes
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance_test.go Outdated Show resolved Hide resolved
yussufsh
yussufsh requested changes Dec 20, 2023
View reviewed changes
ibm/service/power/resource_ibm_pi_instance.go Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_instance.go Outdated Show resolved Hide resolved
@michaelkad
VMRM
f2750ab 
- Add VM no storage to deployment type
- Add virtual optical device
- Update err msg
- Add missing change
- Add isWaitForPIInstanceShutoff
- Modify update vopt
@michaelkad
Copy link
Collaborator Author

@yussufsh, @hkantare can I have review on this PR?

@ismirlia
Copy link
Collaborator

ismirlia commented Feb 8, 2024

Please merge this feature as well if there are no further comments @yussufsh and @hkantare .

@hkantare hkantare merged commit 3694e35 into master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@ismirlia ismirlia ismirlia approved these changes

@yussufsh yussufsh Awaiting requested review from yussufsh

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelkad @ismirlia @yussufsh @hkantare