Add Crn attribute #5107
Merged
Add Crn attribute #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
yussufsh
requested changes
Feb 2, 2024
michaelkad
reviewed
Feb 5, 2024
ismirlia
force-pushed
the
crn-attribute
branch
from
b4ccbc5
to
8af302b
Compare
|
Sorry I accidentally pushed to this branch thinking I was committing to a different repo. This should be fixed now. |
michaelkad
requested changes
Feb 12, 2024
yussufsh
reviewed
Feb 15, 2024
|
Test Results:--- PASS: TestAccIBMPIWorkspaceBasic (144.96s) |
michaelkad
reviewed
Feb 20, 2024
michaelkad
reviewed
Feb 20, 2024
michaelkad
reviewed
Feb 20, 2024
michaelkad
reviewed
Feb 20, 2024
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
yussufsh
approved these changes
Feb 21, 2024
michaelkad
approved these changes
Feb 21, 2024
michaelkad
approved these changes
Feb 26, 2024
ismirlia
pushed a commit
to powervs-ibm/terraform-provider-ibm
that referenced
this pull request
Mar 4, 2024
* Add return crn attribute * Update doc * Update website/docs/d/pi_workspace.html.markdown Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com> * Update resource documents * Add attribute to resource doc * workspace attr * Add Attr_CreationDate * Resolve conflicts * Add Attr_WorkspaceDetails in resource schema * Update ibm/service/power/resource_ibm_pi_workspace_test.go Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com> * Update ibm/service/power/resource_ibm_pi_workspace_test.go Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com> * Update website/docs/r/pi_workspace.html.markdown Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com> --------- Co-authored-by: michaelkad <45772690+michaelkad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: