Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of service credentials secrets in secrets list data source #5173

Merged
merged 1 commit into from Mar 5, 2024

Conversation

haimsch
Copy link
Collaborator

@haimsch haimsch commented Mar 5, 2024

Fix issue where sm_secrets data source (list secrets) fails when instance has secrets of type service credentials.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@haimsch haimsch requested a review from hkantare March 5, 2024 14:43
@hkantare hkantare merged commit 29fc9f6 into master Mar 5, 2024
1 check passed
@haimsch haimsch deleted the sm_fix_list_secrets branch March 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants