Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting service_endpoints default from the plugin #5218

Merged
merged 1 commit into from Mar 30, 2024

Conversation

obai-1
Copy link
Collaborator

@obai-1 obai-1 commented Mar 20, 2024

This avoids setting a default value for service_endpoints in the Terraform provider plugin. This allows the default to be set by the backend according to the compliance standard in use at the specific region.

Users still have the option to specify one of the following values public, private, or public-and-private for service_endpoints. If user leaves service_endpoints empty, the default value will be set based on the compliance standard in the region where the instance is being created. Generally, if the region is enabled with FS Cloud/ENS High compliance, then the default would be private. Otherwise, the default would be public. During any update, if you leave service_endpoints empty, it will maintain the previously selected value.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@obai-1 obai-1 changed the title Avoid setting service_endpoint default from the plugin Avoid setting service_endpoints default from the plugin Mar 20, 2024
Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃コ

@hkantare hkantare merged commit 2227023 into IBM-Cloud:master Mar 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants