Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Power VPN #5226

Merged
merged 6 commits into from Mar 24, 2024
Merged

Deprecate Power VPN #5226

merged 6 commits into from Mar 24, 2024

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

commit 22d453e
Author: michael kad <michaelkad>
Date:   Fri Dec 15 13:02:43 2023 -0600

    update power version

commit 9c4a4a3
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:22:02 2023 -0600

    Update version to 1.5.6

commit c502e95
Merge: 3c4a908 cb423dc
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:19:05 2023 -0600

    Merge remote-tracking branch 'upstream/master' into remove_vpn_create

commit 3c4a908
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:10:37 2023 -0600

    Update version to 1.5.6

commit 4519fba
Merge: 50b0ceb d05f916
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:09:11 2023 -0600

    Merge remote-tracking branch 'origin/master' into remove_vpn_create

commit 50b0ceb
Author: michaelkad <michaelkadiayi@gmail.com>
Date:   Mon Oct 9 16:12:12 2023 -0500

    Update text

commit 359098b
Author: michaelkad <michaelkadiayi@gmail.com>
Date:   Mon Oct 9 16:09:30 2023 -0500

    Add Deprectated for VPN Create
@michaelkad michaelkad added the service/Power Systems Issues related to Power Systems label Mar 21, 2024
@michaelkad
Copy link
Collaborator Author

@hkantare Would you assist with review for this PR please?

Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hkantare hkantare merged commit 08e47de into master Mar 24, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
* Squashed commit of the following:

commit 22d453e
Author: michael kad <michaelkad>
Date:   Fri Dec 15 13:02:43 2023 -0600

    update power version

commit 9c4a4a3
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:22:02 2023 -0600

    Update version to 1.5.6

commit c502e95
Merge: 3c4a908 cb423dc
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:19:05 2023 -0600

    Merge remote-tracking branch 'upstream/master' into remove_vpn_create

commit 3c4a908
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:10:37 2023 -0600

    Update version to 1.5.6

commit 4519fba
Merge: 50b0ceb d05f916
Author: Michael Kadiayi <Michael.Kadiayi@ibm.com>
Date:   Thu Dec 14 12:09:11 2023 -0600

    Merge remote-tracking branch 'origin/master' into remove_vpn_create

commit 50b0ceb
Author: michaelkad <michaelkadiayi@gmail.com>
Date:   Mon Oct 9 16:12:12 2023 -0500

    Update text

commit 359098b
Author: michaelkad <michaelkadiayi@gmail.com>
Date:   Mon Oct 9 16:09:30 2023 -0500

    Add Deprectated for VPN Create

* Add remove vpn

* Add link to depraceted

* Update go.mod

* Fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants